From 7474cf01181c161a56542b445fb102b83b130809 Mon Sep 17 00:00:00 2001 From: Adam Coddington Date: Thu, 14 Aug 2014 21:38:52 -0700 Subject: [PATCH] Prevent ImapTransport from raising exception when no messages are available. Fixes #24. Release 3.4.1. --- django_mailbox/transports/imap.py | 8 +++++++- setup.py | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/django_mailbox/transports/imap.py b/django_mailbox/transports/imap.py index 044838b..62ebf39 100644 --- a/django_mailbox/transports/imap.py +++ b/django_mailbox/transports/imap.py @@ -36,7 +36,13 @@ class ImapTransport(EmailTransport): def _get_all_message_ids(self): # Fetch all the message uids response, message_ids = self.server.uid('search', None, 'ALL') - return message_ids[0].split(' ') + message_id_string = message_ids[0].strip() + # Usually `message_id_string` will be a list of space-separated + # ids; we must make sure that it isn't an empty string before + # splitting into individual UIDs. + if message_id_string: + return message_id_string.split(' ') + return [] def _get_small_message_ids(self, message_ids): # Using existing message uids, get the sizes and diff --git a/setup.py b/setup.py index e5bb0c4..fe50575 100755 --- a/setup.py +++ b/setup.py @@ -11,7 +11,7 @@ gmail_oauth2_require = [ setup( name='django-mailbox', - version='3.4', + version='3.4.1', url='http://github.com/coddingtonbear/django-mailbox/', description=( 'Import mail from POP3, IMAP, local mailboxes or directly from '