From e151006582f417b4c00ec94cd80476ff3492534f Mon Sep 17 00:00:00 2001
From: Thomas Chamberlin <tchamber@nrao.edu>
Date: Fri, 9 Mar 2018 15:35:38 -0500
Subject: [PATCH] Fixed bug in mailbox_name argument and added unit tests

This is an optional positional argument, and thus needs to have nargs='?' set
---
 .../commands/processincomingmessage.py        |  1 +
 .../tests/test_processincomingmessage.py      | 54 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 django_mailbox/tests/test_processincomingmessage.py

diff --git a/django_mailbox/management/commands/processincomingmessage.py b/django_mailbox/management/commands/processincomingmessage.py
index 42276d1..384c585 100644
--- a/django_mailbox/management/commands/processincomingmessage.py
+++ b/django_mailbox/management/commands/processincomingmessage.py
@@ -21,6 +21,7 @@ class Command(BaseCommand):
     def add_arguments(self, parser):
         parser.add_argument(
             'mailbox_name',
+            nargs='?',
             help="The name of the mailbox that will receive the message"
         )
 
diff --git a/django_mailbox/tests/test_processincomingmessage.py b/django_mailbox/tests/test_processincomingmessage.py
new file mode 100644
index 0000000..df5362d
--- /dev/null
+++ b/django_mailbox/tests/test_processincomingmessage.py
@@ -0,0 +1,54 @@
+from django.core.management import call_command, CommandError
+from django.test import TestCase
+
+import mock
+
+class CommandsTestCase(TestCase):
+    def test_processincomingmessage_no_args(self):
+        """Check that processincomingmessage works with no args"""
+        # Mock handle so that the test doesn't hang waiting for input. Note that we are only testing
+        # the argument parsing here -- functionality should be tested elsewhere
+        with mock.patch('django_mailbox.management.commands.processincomingmessage.Command.handle') as handle:
+            # Don't care about the return value
+            handle.return_value = None
+            
+            call_command('processincomingmessage')
+            
+            # Define the arguments we expect handle to be called with
+            required_arguments = {
+                # This should be None, since it isn't given
+                'mailbox_name': None,
+                # All otheres can be anything; we don't care about them at all
+                'no_color': mock.ANY,
+                'pythonpath': mock.ANY,
+                'settings': mock.ANY,
+                'skip_checks': mock.ANY,
+                'traceback': mock.ANY,
+                'verbosity': mock.ANY
+            }
+            # Make sure that we called with the right arguments
+            handle.assert_called_with(**required_arguments)
+
+    def test_processincomingmessage_with_arg(self):
+        """Check that processincomingmessage works with mailbox_name given"""
+
+        with mock.patch('django_mailbox.management.commands.processincomingmessage.Command.handle') as handle:
+            handle.return_value = None
+            
+            call_command('processincomingmessage', 'foo_mailbox')
+
+            required_arguments = {
+                'mailbox_name': 'foo_mailbox',
+                'no_color': mock.ANY,
+                'pythonpath': mock.ANY,
+                'settings': mock.ANY,
+                'skip_checks': mock.ANY,
+                'traceback': mock.ANY,
+                'verbosity': mock.ANY
+            }
+            handle.assert_called_with(**required_arguments)
+
+    def test_processincomingmessage_too_many_args(self):
+        """Check that processincomingmessage raises an error if too many args"""
+        with self.assertRaises(CommandError):
+            call_command('processincomingmessage', 'foo_mailbox', 'invalid_arg')