From 60ccc9a194fe5f4477f2541e264ccf89e6fec792 Mon Sep 17 00:00:00 2001 From: Tonis Date: Tue, 14 Mar 2017 08:26:33 +0200 Subject: [PATCH 1/2] Allow blank eml added verbose name for messages --- django_mailbox/models.py | 16 ++++++++++++---- django_mailbox/tests/test_process_email.py | 2 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/django_mailbox/models.py b/django_mailbox/models.py index 89eb0ad..be74778 100644 --- a/django_mailbox/models.py +++ b/django_mailbox/models.py @@ -34,6 +34,8 @@ from django_mailbox.transports import Pop3Transport, ImapTransport, \ MaildirTransport, MboxTransport, BabylTransport, MHTransport, \ MMDFTransport, GmailImapTransport +from lino.core.fields import NullCharField + logger = logging.getLogger(__name__) @@ -64,8 +66,8 @@ class Mailbox(models.Model): "contain illegal characters (like @, :, etc)." )), blank=True, - null=True, - default=None, + # null=True, + default="", ) from_email = models.CharField( @@ -81,8 +83,8 @@ class Mailbox(models.Model): "be set to match the setting `DEFAULT_FROM_EMAIL`." )), blank=True, - null=True, - default=None, + # null=True, + default="", ) active = models.BooleanField( @@ -419,6 +421,11 @@ class UnreadMessageManager(models.Manager): class Message(models.Model): + + class Meta: + verbose_name = _("Message") + verbose_name_plural = _("Messages") + mailbox = models.ForeignKey( Mailbox, related_name='messages', @@ -483,6 +490,7 @@ class Message(models.Model): eml = models.FileField( _(u'Raw message contents'), null=True, + blank=True, upload_to="messages", help_text=_(u'Original full content of message') ) diff --git a/django_mailbox/tests/test_process_email.py b/django_mailbox/tests/test_process_email.py index f265bdc..1421821 100644 --- a/django_mailbox/tests/test_process_email.py +++ b/django_mailbox/tests/test_process_email.py @@ -382,7 +382,7 @@ class TestProcessEmail(EmailMessageTestCase): self.assertEqual(actual_from, msg.from_header) - reply_email_object.from_email = None + reply_email_object.from_email = "" with mock.patch.object(reply_email_object, 'send'): second_reply_msg = msg.reply(reply_email_object) From 98cbce5f6cceebd816c5d9731f2433d955864c5b Mon Sep 17 00:00:00 2001 From: Tonis Date: Sat, 18 Mar 2017 14:23:03 +0200 Subject: [PATCH 2/2] Message.processed default to now rather than auto_now_add = True https://code.djangoproject.com/ticket/22995 ticket # 1587 --- django_mailbox/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/django_mailbox/models.py b/django_mailbox/models.py index be74778..a9f7905 100644 --- a/django_mailbox/models.py +++ b/django_mailbox/models.py @@ -477,7 +477,7 @@ class Message(models.Model): processed = models.DateTimeField( _('Processed'), - auto_now_add=True + default=now ) read = models.DateTimeField(